Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign Dns Custom resolver resource and deprecate Custom resolver location #3820

Merged
merged 11 commits into from
Jun 7, 2022
Merged

Redesign Dns Custom resolver resource and deprecate Custom resolver location #3820

merged 11 commits into from
Jun 7, 2022

Conversation

sandeep645
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@sandeep645
Copy link
Contributor Author

sandeep645 commented Jun 2, 2022 •
edited
Loading

This PR will address this issue #3804

ibm_dns_custom_resolver_location will be deprecated .
Docs : #3817

@sandeep645
Copy link
Contributor Author

sandeep645 commented Jun 2, 2022 •
edited
Loading

Test Results for Custom resolver :
image

sandeeps@Sandeeps-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_test.go  TESTARGS='-run=TestAccIBMPrivateDNSCustomResolver_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_test.go -v -run=TestAccIBMPrivateDNSCustomResolver_basic -timeout 700m
=== RUN   TestAccIBMPrivateDNSCustomResolver_basic
--- PASS: TestAccIBMPrivateDNSCustomResolver_basic (259.30s)
PASS
ok  	command-line-arguments	260.315s

@sandeep645 sandeep645 changed the title fix : Dns custom resolver resource Redesign Dns Custom resolver resource and deprecate Custom resolver location Jun 2, 2022
@sandeep645
Copy link
Contributor Author

Test Results for Custom resolver location.

malark@Malars-MacBook-Pro terraform-provider-ibm % make testacc TEST=./ibm/service/dnsservices TESTARGS='-run=TestAccIBMPrivateDNSCustomResolverLocations_basic'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./ibm/service/dnsservices -v -run=TestAccIBMPrivateDNSCustomResolverLocations_basic -timeout 700m

.....
=== RUN   TestAccIBMPrivateDNSCustomResolverLocations_basic
--- PASS: TestAccIBMPrivateDNSCustomResolverLocations_basic (306.78s)
PASS
ok  	github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/dnsservices	308.220s

@MalarvizhiK MalarvizhiK mentioned this pull request Jun 7, 2022
Closed
kavya498
kavya498 reviewed Jun 7, 2022
View reviewed changes
ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver.go
DiffSuppressFunc: flex.ApplyOnce,
Type: schema.TypeList,
Description: "Locations on which the custom resolver will be running",
Optional: true,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add maxItems : 3 in schema instead of validating inside code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed .

ibm/service/dnsservices/resource_ibm_private_dns_custom_resolver_location.go Outdated
@@ -76,7 +76,7 @@ func ResourceIBMPrivateDNSCRLocation() *schema.Resource {
pdnsCustomReolverEnabled: {
Type: schema.TypeBool,
Optional: true,
Default: true,
Default: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert all changes made to location resource As it is going to be deprecated..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add deprecation message to location resource
Something similar to https://github.com/IBM-Cloud/terraform-provider-ibm/blob/master/ibm/service/power/resource_ibm_pi_network_port.go#L74

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed .

@hkantare hkantare merged commit 54fdb62 into IBM-Cloud:master Jun 7, 2022
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@sandeep645 @SunithaGudisagarIBM1
Redesign Dns Custom resolver resource and deprecate Custom resolver l…
f6a0e7d 
…ocation (IBM-Cloud#3820)

* fix : custom resolver locations

* fix : update documentation

* fix : Redesign Custom resolver

* fix : Custom resolver location with added validations and error handling

* fix : make fmt

* fix : change default value

* fix : Address review comments

Co-authored-by: Sandeep S <Sandeep.S1@ibm.com>
SunithaGudisagarIBM pushed a commit to ibm-vpc/terraform-provider-ibm that referenced this pull request Sep 14, 2022
@sandeep645 @SunithaGudisagarIBM1
Redesign Dns Custom resolver resource and deprecate Custom resolver l…
ad2d288 
…ocation (IBM-Cloud#3820)

* fix : custom resolver locations

* fix : update documentation

* fix : Redesign Custom resolver

* fix : Custom resolver location with added validations and error handling

* fix : make fmt

* fix : change default value

* fix : Address review comments

Co-authored-by: Sandeep S <Sandeep.S1@ibm.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavya498 kavya498 kavya498 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeep645 @kavya498 @hkantare