CIS - Delete filter on deletion of Firewall Rules #3963
Conversation
| @@ -238,6 +238,21 @@ func ResourceIBMCISFirewallrulesDelete(context context.Context, d *schema.Resour | |||
| return diag.FromErr(fmt.Errorf("[ERROR] Error deleting the custom resolver %s:%s", err, response)) | |||
| } | |||
|
|
|||
| if id, ok := d.GetOk(cisFilterID); ok { | |||
There was a problem hiding this comment.
Can we use same filterID forother rules. If we delete the filterID will not be other firewall rules not effected?
If user create a filter using Terraform is the destroy not handled to remove filter
There was a problem hiding this comment.
No we can not use same filter for other rules. It throws an error on creating a new rule with an already mapped filterID.
There was a problem hiding this comment.
Yes, destroy handles filter deletion but it does not cover old filters.
|
please share the testcase execution results |
|
Testcase results - |
|
|
||
| filter_id := id.(string) | ||
| filterOpt := cisFilterClient.NewDeleteFiltersOptions(xAuthtoken, crn, zoneID, filter_id) | ||
| _, _, err = cisFilterClient.DeleteFilters(filterOpt) |
There was a problem hiding this comment.
if a template deletes filter as part of destroy and when a firewall rule makes again same delete call willnot that fail with 404?
should we handle this case?
Can you write tempalte
which creates filter and use that filter in rule and then run destroy
| @@ -71,10 +71,12 @@ func ResourceIBMCISDomain() *schema.Resource { | |||
| cisDomainVerificationKey: { | |||
| Type: schema.TypeString, | |||
| Computed: true, | |||
| Optional: true, | |||
There was a problem hiding this comment.
why is this marked as optional we are just setting the value in Read method
| }, | ||
| cisDomainCnameSuffix: { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| Optional: true, |
* delete filter along with firewall rule * added partial check * removed optional Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
* delete filter along with firewall rule * added partial check * removed optional Co-authored-by: Arpit Srivastava <arpit-mac@Arpits-MacBook-Pro.local>
Problem statement -
Issue - https://github.ibm.com/NetworkTribe/CIS_Support/issues/2515