Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(tpm): support for bare metal secure boot and tpm #4343

Merged
merged 1 commit into from
Mar 23, 2023
Merged

enhancement(tpm): support for bare metal secure boot and tpm #4343

merged 1 commit into from
Mar 23, 2023

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Feb 10, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMISBareMetalServer_SecureBoot_tpm
no message sent
no message sent
--- PASS: TestAccIBMISBareMetalServer_SecureBoot_tpm (1467.54s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1469.590s

@uibm uibm marked this pull request as ready for review February 15, 2023 04:57
@kavya498
Copy link
Collaborator

kavya498 commented Mar 8, 2023

@ujjwal-ibm
Can you please rebase the pr?
Can you please attach testcase results to the PR?

@uibm uibm force-pushed the bm-secure-boot branch 2 times, most recently from 6b963d2 to 0982e4a Compare March 23, 2023 06:20
@uibm uibm requested a review from hkantare March 23, 2023 09:14
@uibm
Copy link
Collaborator Author

uibm commented Mar 23, 2023 

=== RUN   TestAccIBMISBareMetalServer_SecureBoot_tpm
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
no message sent
--- PASS: TestAccIBMISBareMetalServer_SecureBoot_tpm (1577.14s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1579.144s

@uibm uibm marked this pull request as draft March 23, 2023 12:17
@uibm uibm marked this pull request as ready for review March 23, 2023 12:46
@uibm
Copy link
Collaborator Author

uibm commented Mar 23, 2023 

=== RUN   TestAccIBMISBareMetalServer_basic
no message sent
--- PASS: TestAccIBMISBareMetalServer_basic (932.78s)
=== RUN   TestAccIBMISBareMetalServer_basic_reserved_ip
no message sent
--- PASS: TestAccIBMISBareMetalServer_basic_reserved_ip (897.66s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     1832.479s

@hkantare hkantare merged commit 40a3bcb into IBM-Cloud:master Mar 23, 2023
@uibm uibm deleted the bm-secure-boot branch March 23, 2023 13:50
omaraibrahim pushed a commit to omaraibrahim/terraform-provider-ibm that referenced this pull request Jul 20, 2023
@uibm @omaraibrahim
enhancement(tpm): support for bare metal secure boot and tpm (IBM-Clo…
c627790 
…ud#4343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkantare hkantare hkantare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uibm @kavya498 @hkantare