Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bluemix-go to latest #4870

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

mihivagyok
Copy link
Contributor

Fixes #4861
Now the provider will return the right, signed private endpoint. I have used the below terraform script. I have re-executed with the modified provider and the change exactly shows what is changing with this PR.

➜ cat main.tf
data "ibm_container_cluster_config" "cluster_config" {
  cluster_name_id = "ckk267ql07gni06sarlg"
  config_dir      = "/Users/adam/terraform/terraform_output"
  endpoint_type   = "vpe"
}

output "info" {
  value = {
    host = data.ibm_container_cluster_config.cluster_config.host
    config_path = data.ibm_container_cluster_config.cluster_config.config_file_path
  }
}


➜ terraform apply
data.ibm_container_cluster_config.cluster_config: Reading...
data.ibm_container_cluster_config.cluster_config: Read complete after 5s [id=ckk267ql07gni06sarlg]

Changes to Outputs:
  ~ info = {
      ~ host        = "https://c108.private.eu-gb.containers.cloud.ibm.com:32098" -> "https://c108-e.private.eu-gb.containers.cloud.ibm.com:32098"
        # (1 unchanged attribute hidden)
    }

You can apply this plan to save these new output values to the Terraform state, without changing any real infrastructure.

Do you want to perform these actions?
  Terraform will perform the actions described above.
  Only 'yes' will be accepted to approve.

  Enter a value: yes


Apply complete! Resources: 0 added, 0 changed, 0 destroyed.

Outputs:

info = {
  "config_path" = "/Users/adam/terraform/terraform_output/d63d3a277cab0bd1e422ef4045e8537a9c95c1fd929cd19f12dfb887b8b7b19c_ckk267ql07gni06sarlg_k8sconfig/config.yml"
  "host" = "https://c108-e.private.eu-gb.containers.cloud.ibm.com:32098"
}

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@hkantare
Copy link
Collaborator

Fix the go.sum

@hkantare hkantare closed this Oct 19, 2023
@hkantare hkantare reopened this Oct 19, 2023
@mihivagyok
Copy link
Contributor Author

Sure, let me check!

@mihivagyok
Copy link
Contributor Author

@hkantare Done! Thank you for the notice!

@hkantare hkantare merged commit 821fd9b into IBM-Cloud:master Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.58.0 ibm_container_cluster_config: new endpoint_type returning self-signed private endpoint
2 participants