Undo gateway change #5570
Merged
Undo gateway change #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The networking team changed their mind wants to continue allowing gateway updates.
ismirlia
requested review from
yussufsh,
hkantare,
michaelkad and
Alexander-Kita
yussufsh
reviewed
Aug 27, 2024
| body.IPAddressRanges = getIPAddressRanges(d.Get(helpers.PINetworkIPAddressRange).([]interface{})) | ||
| } | ||
| if d.HasChange(helpers.PINetworkGateway) { | ||
| body.Gateway = flex.PtrToString(d.Get(helpers.PINetworkGateway).(string)) |
There was a problem hiding this comment.
body.Gateway is *string and PtrToString takes a string and outputs a *string. I think the flex function might be named backwards.
yussufsh
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The networking team changed their mind wants to continue allowing gateway updates. This undoes part of the changes in #5503.