Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add orphan_resource_on_delete argument to worker pool resources #5705

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

z0za
Copy link
Contributor

@z0za z0za commented Oct 7, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

=== RUN   TestAccIBMContainerVpcClusterWorkerPoolBasic
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolBasic (1332.86s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1336.034s

=== RUN   TestAccIBMContainerWorkerPoolBasic
--- PASS: TestAccIBMContainerWorkerPoolBasic (1584.97s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1588.354s

after rebase the tests look good

=== RUN   TestAccIBMContainerWorkerPoolBasic
--- PASS: TestAccIBMContainerWorkerPoolBasic (1656.27s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1670.290s

=== RUN   TestAccIBMContainerVpcClusterWorkerPoolBasic
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolBasic (2232.08s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      2239.474s

after var renames

=== RUN   TestAccIBMContainerVpcClusterWorkerPoolBasic
--- PASS: TestAccIBMContainerVpcClusterWorkerPoolBasic (1545.40s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1552.393s

=== RUN   TestAccIBMContainerWorkerPoolBasic
--- PASS: TestAccIBMContainerWorkerPoolBasic (1711.53s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/kubernetes      1721.652s

@z0za z0za force-pushed the workerpool_delete branch from 2ff2ecb to d9e98bc Compare October 10, 2024 11:17
z0za and others added 2 commits October 11, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants