-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fix #5723
bug fix #5723
Conversation
@@ -77,75 +78,17 @@ func DataSourceIbmConfigAggregatorConfigurations() *schema.Resource { | |||
Elem: &schema.Resource{ | |||
Schema: map[string]*schema.Schema{ | |||
"about": &schema.Schema{ | |||
Type: schema.TypeList, | |||
Type: schema.TypeMap, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we go with Typemap then we have limitation from Terraform only can hold only string type. If you have combination of multiple types (string ,int, bool) then this will not be compatible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you think of declaring it string as json
https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/resource_key#credentials_json chk this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All fields of this attribute are of type string so there is no modification required.
we shd have doc changes also |
The changes were made to modify the output, the input remains the same. So doc changes wouldn't be necessary. |
It requires doc changes since we changed the schema type check personal slack for more details |
if err != nil { | ||
return "", err | ||
} | ||
fmt.Println(string(jsonData)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this fmt stmt
https://github.ibm.com/devx-app-services/configuration-aggregator-planning/issues/337