Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ibm_is_share): 404 error fix on datasource #5770

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

uibm
Copy link
Collaborator

@uibm uibm commented Nov 6, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

 % make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIbmIsShareDataSource404'
=== RUN   TestAccIbmIsShareDataSource404
--- PASS: TestAccIbmIsShareDataSource404 (2.70s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     4.360s
% make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIbmIsSourceShareDataSource404'
=== RUN   TestAccIbmIsSourceShareDataSource404
--- PASS: TestAccIbmIsSourceShareDataSource404 (3.36s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     5.387s

@uibm uibm requested a review from hkantare November 7, 2024 04:38
@uibm
Copy link
Collaborator Author

uibm commented Nov 7, 2024

image image

@hkantare hkantare merged commit c15509e into IBM-Cloud:master Nov 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants