-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm charts refactor proposal #139
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tomcli
changed the title
[WIP] Helm charts refactor proposal
Helm charts refactor proposal
Oct 5, 2018
Update: I rewritten the instructions and travis CI to use the helm charts only for deployment. Since the GitHub page won't be available until we merge it to master, anyone who wants to test it should use the below commands that use the local helm charts. export NAMESPACE=default
export SHARED_VOLUME_STORAGE_CLASS="ibmc-file-gold";
helm install docs/helm-charts/ibmcloud-object-storage-plugin-0.1.tgz --set namespace=$NAMESPACE
helm install docs/helm-charts/ffdl-helper-0.1.1.tgz --set namespace=$NAMESPACE,shared_volume_storage_class=$SHARED_VOLUME_STORAGE_CLASS --wait
helm install docs/helm-charts/ffdl-core-0.1.1.tgz --set namespace=$NAMESPACE,lcm.shared_volume_storage_class=$SHARED_VOLUME_STORAGE_CLASS --wait |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As many users complaint about the usability of FfDL (a lots of them are regrading the deployment). We might want to deprecate the makefile approach because it's very scripted. Instead, I refactor the helm charts and convert some scripts such as creating the configmaps as part of the helm deployment. I also break down the current 2 helm charts into the below 3
With this approach, we can deprecate the
make deploy/quickstart-deploy
to using 3 helm commands (Assuming Helm charts are hosted on our GitHub Pages)Having multiple helm charts allow users to delete/rollback their core ffdl charts without touching many of the infrastructure to help the development/testing process faster. This might also help with DLaaS because we can make the ffdl-core helm charts more concise.
Note this is a proposal PR with the helm charts. If we agree to work on this, we need to to deprecate the make deploy and publish the helm charts using GitHub-Pages (Will be published once merged to master branch).
Developer's Certificate of Origin 1.1