Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple RNN Cells and Layers #358

Merged
merged 9 commits into from
May 4, 2022
Merged

Multiple RNN Cells and Layers #358

merged 9 commits into from
May 4, 2022

Conversation

Jo7701
Copy link
Contributor

@Jo7701 Jo7701 commented Mar 9, 2022

Created a wrapper AnalogRNN class that accepts different cells (LSTM, GRU, VanillaRNN). Also has the option of creating a bidirectional layer.

3 files were created: cells.py, layers.py, and rnn.py. All of these are in a rnn folder in nn/modules.

@maljoras maljoras self-requested a review March 9, 2022 20:01
@maljoras maljoras added the enhancement New feature or request label Mar 9, 2022
@charlesmackin
Copy link
Collaborator

This looks great, thanks for the addition!

@maljoras
Copy link
Collaborator

@Jo7701 many thanks for the contribution! If you could add the tests, then we would be able to merge it soon.

@maljoras
Copy link
Collaborator

maljoras commented May 3, 2022

@Jo7701 Many thanks again for this great contribution. I took the liberty to polish your code somewhat. It now works fine for CUDA as well. Thanks again, I will merge it very soon.

@kaoutar55
Copy link
Collaborator

Thank you @Jo7701 for these great additions! Thank you @maljoras for the detailed review and the enhancements.

@kaoutar55 kaoutar55 merged commit 328a57f into IBM:master May 4, 2022
maljoras pushed a commit to todd-deshane/aihwkit that referenced this pull request Jul 26, 2022
* Added multiple RNN cell/layer functionality

* Finished multiple rnn functionality

* Modified rnn example and finished rnn testing

* init

* examples cuda fixes

* skip large conversion

* change log

* pycodestyle

Co-authored-by: Malte Rasch <malte.rasch@ibm.com>
Signed-off-by: Malte Rasch <malte.rasch@ibm.com>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 6, 2022
* Added multiple RNN cell/layer functionality

* Finished multiple rnn functionality

* Modified rnn example and finished rnn testing

* init

* examples cuda fixes

* skip large conversion

* change log

* pycodestyle

Co-authored-by: Malte Rasch <malte.rasch@ibm.com>
Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
* Added multiple RNN cell/layer functionality

* Finished multiple rnn functionality

* Modified rnn example and finished rnn testing

* init

* examples cuda fixes

* skip large conversion

* change log

* pycodestyle

Co-authored-by: Malte Rasch <malte.rasch@ibm.com>
Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
* Added multiple RNN cell/layer functionality

* Finished multiple rnn functionality

* Modified rnn example and finished rnn testing

* init

* examples cuda fixes

* skip large conversion

* change log

* pycodestyle

Co-authored-by: Malte Rasch <malte.rasch@ibm.com>
Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11 pushed a commit to HCY-11/aihwkit that referenced this pull request Dec 7, 2022
* Added multiple RNN cell/layer functionality

* Finished multiple rnn functionality

* Modified rnn example and finished rnn testing

* init

* examples cuda fixes

* skip large conversion

* change log

* pycodestyle

Co-authored-by: Malte Rasch <malte.rasch@ibm.com>
Signed-off-by: Henry Ye <yehenry11@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants