Multiple RNN Cells and Layers #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks for the addition! |
|
@Jo7701 many thanks for the contribution! If you could add the tests, then we would be able to merge it soon. |
|
@Jo7701 Many thanks again for this great contribution. I took the liberty to polish your code somewhat. It now works fine for CUDA as well. Thanks again, I will merge it very soon. |
maljoras
approved these changes
May 3, 2022
maljoras
pushed a commit
to todd-deshane/aihwkit
that referenced
this pull request
Jul 26, 2022
* Added multiple RNN cell/layer functionality * Finished multiple rnn functionality * Modified rnn example and finished rnn testing * init * examples cuda fixes * skip large conversion * change log * pycodestyle Co-authored-by: Malte Rasch <malte.rasch@ibm.com> Signed-off-by: Malte Rasch <malte.rasch@ibm.com>
HCY-11
pushed a commit
to HCY-11/aihwkit
that referenced
this pull request
Dec 6, 2022
* Added multiple RNN cell/layer functionality * Finished multiple rnn functionality * Modified rnn example and finished rnn testing * init * examples cuda fixes * skip large conversion * change log * pycodestyle Co-authored-by: Malte Rasch <malte.rasch@ibm.com> Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11
pushed a commit
to HCY-11/aihwkit
that referenced
this pull request
Dec 7, 2022
* Added multiple RNN cell/layer functionality * Finished multiple rnn functionality * Modified rnn example and finished rnn testing * init * examples cuda fixes * skip large conversion * change log * pycodestyle Co-authored-by: Malte Rasch <malte.rasch@ibm.com> Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11
pushed a commit
to HCY-11/aihwkit
that referenced
this pull request
Dec 7, 2022
* Added multiple RNN cell/layer functionality * Finished multiple rnn functionality * Modified rnn example and finished rnn testing * init * examples cuda fixes * skip large conversion * change log * pycodestyle Co-authored-by: Malte Rasch <malte.rasch@ibm.com> Signed-off-by: Henry Ye <yehenry11@gmail.com>
HCY-11
pushed a commit
to HCY-11/aihwkit
that referenced
this pull request
Dec 7, 2022
* Added multiple RNN cell/layer functionality * Finished multiple rnn functionality * Modified rnn example and finished rnn testing * init * examples cuda fixes * skip large conversion * change log * pycodestyle Co-authored-by: Malte Rasch <malte.rasch@ibm.com> Signed-off-by: Henry Ye <yehenry11@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a wrapper AnalogRNN class that accepts different cells (LSTM, GRU, VanillaRNN). Also has the option of creating a bidirectional layer.
3 files were created: cells.py, layers.py, and rnn.py. All of these are in a rnn folder in nn/modules.