Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "self-healing" when service state inconsistent #262

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

JohnStarich
Copy link
Member

In the early days of IBM Cloud Operator, self-healing was added with the intent to reconcile a Service in an inconsistent state by recreating the service instance.

This can be very destructive for critical services like databases, so this PR removes the service deletion.

Signed-off-by: John Starich <johnstarich@johnstarich.com>
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #262 (892d009) into master (8c24507) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   92.82%   92.80%   -0.03%     
==========================================
  Files           9        9              
  Lines        1171     1167       -4     
==========================================
- Hits         1087     1083       -4     
  Misses         56       56              
  Partials       28       28              
Impacted Files Coverage Δ
controllers/service_controller.go 97.88% <ø> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c24507...892d009. Read the comment docs.

@JohnStarich JohnStarich merged commit 0be0e4d into master Oct 13, 2021
@JohnStarich JohnStarich deleted the bugfix/remove-status-update-fail-service-delete branch October 13, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants