Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix assertion order in session tests #602

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

ricellis
Copy link
Member

PR summary

Some minor clean ups in the session tests.

Associated with s681 and #599

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the
    Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • New tests
  • Build/CI related changes - test cleanup
  • Documentation content changes
  • Other (please describe)

What is the current behavior?

When reviewing #599 I noticed that some of the test assertion expected/actual were reversed. This gave confusing messages when tests failed.

What is the new behavior?

  • Correct the assertion method arg order to give correct messages
  • Remove unused import
  • MockWebServer is a Closeable so we can use try-with-resources for a cleaner test

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ricellis ricellis self-assigned this Sep 10, 2024
@ricellis ricellis merged commit c97cae1 into main Sep 11, 2024
8 checks passed
@ricellis ricellis deleted the s681-session-test-cleanup branch September 11, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants