Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event sourcing setup in chart templates #127

Merged
merged 3 commits into from
Jan 22, 2023
Merged

Fix event sourcing setup in chart templates #127

merged 3 commits into from
Jan 22, 2023

Conversation

gonzalesraul
Copy link
Contributor

  • Fix flag control in chart template for event source feature
  • Fix missing pullPolicy mapping from values to template
  • Add minikube sample values to play with it
  • Update gitignore

@gonzalesraul
Drop idea IDE config from git
4fa9825 
Signed-off-by: Raul Gonzales <gonzalesraul03@gmail.com>
@gonzalesraul
Fix event sourcing template in chart template
aea48c9 
Signed-off-by: Raul Gonzales <gonzalesraul03@gmail.com>
@gonzalesraul
Add minikube values
a6397c2 
Signed-off-by: Raul Gonzales <gonzalesraul03@gmail.com>
@No9
Copy link
Collaborator

No9 commented Jan 21, 2023 •
edited
Loading

Thank you very for this contribution especially for validating the event writer feature.
I'm currently travelling but will merge this in and release next week

@No9 No9 merged commit e8d6a7a into IBM:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@No9 No9 No9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gonzalesraul @No9