Skip to content

Commit

Permalink
Define spark version in .make.versions (#632)
Browse files Browse the repository at this point in the history
* set spark base image tag to that from .make.versions

Signed-off-by: David Wood <dawood@us.ibm.com>

* have spark transform images all use latest by default

Signed-off-by: David Wood <dawood@us.ibm.com>

* restore default spark FROM image to include quay.io

Signed-off-by: David Wood <dawood@us.ibm.com>

* Set base spark version in .make.versions

Signed-off-by: David Wood <dawood@us.ibm.com>

---------

Signed-off-by: David Wood <dawood@us.ibm.com>
  • Loading branch information
daw3rd authored Sep 27, 2024
1 parent bb31e4c commit 4b56f4e
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .make.defaults
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ DOCKER_REGISTRY_KEY?=$(DPK_DOCKER_REGISTRY_KEY)
DOCKER_REGISTRY_ENDPOINT?=$(DOCKER_HOSTNAME)/$(DOCKER_NAMESPACE)
DOCKER_LOCAL_IMAGE=$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)
DOCKER_REMOTE_IMAGE=$(DOCKER_REGISTRY_ENDPOINT)/$(DOCKER_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)
DOCKER_SPARK_BASE_IMAGE_NAME=data-prep-kit-spark-3.5.2
DOCKER_SPARK_BASE_IMAGE_NAME=data-prep-kit-spark-$(SPARK_VERSION)
DOCKER_SPARK_BASE_IMAGE=$(DOCKER_SPARK_BASE_IMAGE_NAME):$(DOCKER_IMAGE_VERSION)
RAY_BASE_IMAGE?=docker.io/rayproject/ray:${RAY}-py310
# Deprecated in favor of DOCKER_REMOTE_IMAGE
Expand Down
1 change: 1 addition & 0 deletions .make.versions
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ KFP_v2_SDK=2.8.0
KFP_v1=1.8.5
KFP_v1_SDK=1.8.22
RAY=2.24.0
SPARK_VERSION=3.5.2

ifeq ($(KFPv2), 1)
WORKFLOW_SUPPORT_LIB=kfp_v2_workflow_support
Expand Down
4 changes: 1 addition & 3 deletions data-processing-lib/spark/Makefile
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
# Use make help, to see the available rules
REPOROOT=../..
include $(REPOROOT)/.make.defaults
SPARK_VERSION=3.5.2
DOCKER_IMAGE_NAME=data-prep-kit-spark-$(SPARK_VERSION)
DOCKER_IMAGE_LIB_NAME=data-prep-kit-spark
DOCKER_IMAGE_NAME=$(DOCKER_SPARK_BASE_IMAGE_NAME)


.check-env::
Expand Down

0 comments on commit 4b56f4e

Please sign in to comment.