Move hack dirs to scripts dir #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
Signed-off-by: Revital Sur <eres@il.ibm.com>
roytman
reviewed
Jun 18, 2024
scripts/kind/tools/ingress.sh
Outdated
| @@ -2,19 +2,19 @@ | |||
|
|
|||
| op=$1 | |||
|
|
|||
| source ${ROOT_DIR}/hack/common.sh | |||
| source ${REPOROOT}/scripts/kind/common.sh | |||
There was a problem hiding this comment.
can you define a local variable {REPOROOT}/scripts/kind, we have too many references to it.
scripts/kind/tools/ingress.sh
Outdated
|
|
||
| deploy() { | ||
| kubectl apply -f ${ROOT_DIR}/hack/ray_api_server_ingress.yaml | ||
| kubectl apply -f ${REPOROOT}/scripts/kind/ray_api_server_ingress.yaml |
There was a problem hiding this comment.
can you add sleep 10 before L:8
daw3rd
requested changes
Jun 18, 2024
transforms/.make.workflows
Outdated
There was a problem hiding this comment.
This is an inconsistent move. A) it is not a shell script and B) if we do this, we should also move .make.defaults, .make.versions,.make.transforms etc. But I'm not sure we want to do this. What was your motivation here?
There was a problem hiding this comment.
@daw3rd transforms/.make.workflows file remains under transforms... are you refering to other file?
Signed-off-by: Revital Sur <eres@il.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/Closes #293
This PR moves the hack subdirs under a new
scriptsdirectoryRelated issue number (if any).
#293