Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix s3 sample data input path (again) #59

Merged
merged 1 commit into from
May 2, 2024
Merged

fix s3 sample data input path (again) #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion transforms/.make.transforms
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ conventions:
.transforms.minio-load::
@# Help: Install the test-data/input files into minio for $(TRANSFORM_NAME)
dir=$$(find $(REPOROOT)/transforms -type d -name $(TRANSFORM_NAME)); \
$(MAKE) MINIO_SRC=$$dir/test-data/input MINIO_DEST=$(TRANSFORM_NAME)/input/ .defaults.minio.load-test-data
$(MAKE) MINIO_SRC=$$dir/test-data/input MINIO_DEST=$(TRANSFORM_NAME)/ .defaults.minio.load-test-data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion is to do

$(MAKE) MINIO_SRC=$$dir/test-data/input/ MINIO_DEST=$(TRANSFORM_NAME)/input .defaults.minio.load-test-data

They both work. The difference is that in your implementation moves the folder, while in what I am suggesting its moving the content of the folder



.PHONY: minio-start
Expand Down