Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline transform #602

Open
wants to merge 16 commits into
base: dev
Choose a base branch
from
Open

pipeline transform #602

wants to merge 16 commits into from

Conversation

blublinsky
Copy link
Collaborator

@blublinsky blublinsky commented Sep 19, 2024

Why are these changes needed?

Implementation of pipeline transform similar to Sklearn approach

Related issue number (if any).

#374
#544

@blublinsky blublinsky marked this pull request as draft September 19, 2024 20:06
@blublinsky blublinsky assigned blublinsky and unassigned blublinsky Sep 19, 2024
@blublinsky blublinsky marked this pull request as ready for review September 21, 2024 18:31
@roytman
Copy link
Member

roytman commented Sep 23, 2024

@daw3rd , I looked over this PR and it is OK for me, but leave it for your final verdict.

Copy link
Member

@daw3rd daw3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run a pipeline outside of the runtime/launcher? If so, I'd like to see a test or other example of how this is done? If not, we need it.

@blublinsky
Copy link
Collaborator Author

Can we run a pipeline outside of the runtime/launcher? If so, I'd like to see a test or other example of how this is done? If not, we need it.

For running a pipeline outside a runtime we have kfp. We can not pass values in memory outside of runtime

@daw3rd
Copy link
Member

daw3rd commented Sep 23, 2024

Can we run a pipeline outside of the runtime/launcher? If so, I'd like to see a test or other example of how this is done? If not, we need it.

For running a pipeline outside a runtime we have kfp. We can not pass values in memory outside of runtime

This is a problem and does not meet requirements defined in the issue. #374 (comment)

@blublinsky
Copy link
Collaborator Author

Can we run a pipeline outside of the runtime/launcher? If so, I'd like to see a test or other example of how this is done? If not, we need it.

For running a pipeline outside a runtime we have kfp. We can not pass values in memory outside of runtime

This is a problem and does not meet requirements defined in the issue. #374 (comment)

The requirement does not specify the ability to run across runtimes. Besides, where is this requirement coming from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants