Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align docling versions among transforms #629

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Conversation

dolfim-ibm
Copy link
Member

Why are these changes needed?

This transform aligns the docling-core version used in pdf2parquet and doc_chunk, which simplified the creation of the single package.

Related issue number (if any).

Signed-off-by: Michele Dolfi <dol@zurich.ibm.com>
@dolfim-ibm dolfim-ibm requested a review from touma-I September 26, 2024 06:35
@touma-I
Copy link
Collaborator

touma-I commented Sep 26, 2024

Thanks @dolfim-ibm I need to make one more change to move all the requirements out of the pyproject.toml and into a requirements.txt. will slack you when this is done.

Signed-off-by: Maroun Touma <touma@us.ibm.com>
Signed-off-by: Maroun Touma <touma@us.ibm.com>
Signed-off-by: Maroun Touma <touma@us.ibm.com>
Copy link
Collaborator

@touma-I touma-I left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dolfim-ibm Looks good. thanks for your patience! I will apply the same when we do the other transforms. I had to list the deep search libraries in the requirements for ray in order for the docker build to pass.

@touma-I touma-I merged commit 5e03856 into dev Sep 26, 2024
6 checks passed
@touma-I touma-I deleted the docling-align-versions branch September 26, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants