Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few changes in the root README #810

Merged
merged 9 commits into from
Nov 19, 2024
Merged

A few changes in the root README #810

merged 9 commits into from
Nov 19, 2024

Conversation

shahrokhDaijavad
Copy link
Member

In addition to addressing #752, three other changes were made:

  1. Adding Web2Parquet to the table, after the merging of Crawler transform #797
  2. Updating the Citations, because the order of authors in the DPK paper has been changed
  3. HTML2parquet has had a KFP implementation for a while, but it was never check-marked in the table.

daw3rd
daw3rd previously requested changes Nov 18, 2024
@@ -49,4 +49,4 @@ Web2Parquet(urls= ['https://thealliance.ai/'],
depth=2,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something looks wrong here. Maybe replace = with (

Copy link
Collaborator

@touma-I touma-I left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks shahorkh. Looks good.

@touma-I touma-I self-requested a review November 19, 2024 01:37
@touma-I touma-I dismissed daw3rd’s stale review November 19, 2024 01:38

The syntax is good. Thanks

@touma-I touma-I merged commit 5f4c347 into dev Nov 19, 2024
1 check passed
@touma-I touma-I deleted the shahrokh_readmestuff branch November 19, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants