Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search path configuration updates #267

Merged

Conversation

dennis-behm
Copy link
Member

@dennis-behm dennis-behm commented Oct 24, 2022

See issue #262.

This PR is cleaning up the dependency and impact search configurations for the removed DependencyResolver and ImpactResolver APIs - see N&N in the DBB docs.

This PR includes:

  • Removal of old configurations
  • Removal of the resolverUtils. Methods are now included in impactUtilities and buildUtilities
  • SearchPath configurations are added to the list of required build properties
  • Updated configurations for SearchPath configs for ZunitConfig.groovy
  • Updated Readme

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm dennis-behm added the enhancement New feature or request label Oct 24, 2022
@lburgess07 lburgess07 self-requested a review November 8, 2022 15:25
Copy link
Contributor

@lburgess07 lburgess07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you are removing the samples/MortgageApplication/application-conf/Assembler.properties file. I imagine you are doing this, and it is safe to do so, because there aren't any ASM source files in MortgageApplication that we are building. So I'm not sure why it was in there in the first place. Just wanted to confirm this is the reason for removal?

@lburgess07
Copy link
Contributor

lburgess07 commented Nov 8, 2022

Also, since we are cleaning up old APIs, can we completely remove the BuildUtilities methods that are commented out:
https://github.com/IBM/dbb-zappbuild/blob/develop/utilities/BuildUtilities.groovy#L308-L353
https://github.com/IBM/dbb-zappbuild/blob/develop/utilities/BuildUtilities.groovy#L689-L715
The commented out methods are supporting APIs that have been removed in 2.0, which is why I commented them out, but I think we should remove the code entirely.

@dennis-behm
Copy link
Member Author

I see that you are removing the samples/MortgageApplication/application-conf/Assembler.properties file. I imagine you are doing this, and it is safe to do so, because there aren't any ASM source files in MortgageApplication that we are building. So I'm not sure why it was in there in the first place. Just wanted to confirm this is the reason for removal?

Yes, I wanted to clean up the Mortgageapplicatio sample. While there is no ASM source, I think we can get rid of it.

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm dennis-behm force-pushed the 262_searchPathConfiguration_updates branch from c79c3e1 to 91667da Compare November 9, 2022 14:34
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
https://github.com/dennis-behm/dbb-zappbuild into
262_searchPathConfiguration_updates

# Conflicts:
#	languages/Assembler.groovy
#	languages/Cobol.groovy
#	languages/PLI.groovy


Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@lburgess07 lburgess07 self-requested a review November 9, 2022 15:40
@dennis-behm dennis-behm merged commit c325e44 into IBM:develop Nov 10, 2022
dennis-behm added a commit to dennis-behm/dbb-zappbuild that referenced this pull request Dec 15, 2022
* Search path configuration updates
* Move methods from resolverUtils to build and impact utilities
* Adding dependencySearch configurations to list of required build props
* Removal of references of old DependencyResolver configuration in application-conf
* Removal of references of old DependencyResolver configuration in MortgageApp

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
dennis-behm added a commit to dennis-behm/dbb-zappbuild that referenced this pull request Dec 15, 2022
* Search path configuration updates
* Move methods from resolverUtils to build and impact utilities
* Adding dependencySearch configurations to list of required build props
* Removal of references of old DependencyResolver configuration in application-conf
* Removal of references of old DependencyResolver configuration in MortgageApp

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@raylamgit
Copy link

raylamgit commented Mar 31, 2023

At Cobol.groovy line 337 I added my codes to switch SYSLMOD from LOAD to CICSLOAD

// If cics then the load will be CICSLOAD
if (buildUtils.isCICS(logicalFile)) {
linkedit.dd(new DDStatement().name("SYSLMOD").dsn("${props.cobol_loadcicsPDS}($member)").options('shr').output(true).deployType(deployType))
}
else
{
linkedit.dd(new DDStatement().name("SYSLMOD").dsn("${props.cobol_loadPDS}($member)").options('shr').output(true).deployType(deployType))
}

It looks like the ImpactUtilities.groovy is checking the LOAD only, and I have the following error, because my load module is at
RLAM.RAYGENAP.CICSLOAD(LGICDB01) Is there a way that I point to a different SYSLMOD and not causing ImpactUtilities to fail.

*** Scanning load module for raygenapp/base/src/COBOL/LGICDB01.cbl
com.ibm.dbb.build.ValidationException: BGZTK0046E Could not scan load module //'RLAM.RAYGENAP.LOAD(LGICDB01)' because it does not exist.
.
at ImpactUtilities.saveStaticLinkDependencies(ImpactUtilities.groovy:909)

def saveStaticLinkDependencies(String buildFile, String loadPDS, LogicalFile logicalFile) {
MetadataStore metadataStore = MetadataStoreFactory.getMetadataStore()
if (metadataStore && !props.error) {
LinkEditScanner scanner = new LinkEditScanner()
if (props.verbose) println "*** Scanning load module for $buildFile"
LogicalFile scannerLogicalFile = scanner.scan(buildUtils.relativizePath(buildFile), loadPDS)
if (props.verbose) println "*** Logical file = \n$scannerLogicalFile"

impactUtilities exception.txt

One way to circumvent my issue it to set cobol_scanLoadModule=false, however this will disable the cobol_scanLoadModule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants