-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search path configuration updates #267
Search path configuration updates #267
Conversation
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you are removing the samples/MortgageApplication/application-conf/Assembler.properties
file. I imagine you are doing this, and it is safe to do so, because there aren't any ASM source files in MortgageApplication that we are building. So I'm not sure why it was in there in the first place. Just wanted to confirm this is the reason for removal?
Also, since we are cleaning up old APIs, can we completely remove the BuildUtilities methods that are commented out: |
Yes, I wanted to clean up the Mortgageapplicatio sample. While there is no ASM source, I think we can get rid of it. |
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
c79c3e1
to
91667da
Compare
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
https://github.com/dennis-behm/dbb-zappbuild into 262_searchPathConfiguration_updates # Conflicts: # languages/Assembler.groovy # languages/Cobol.groovy # languages/PLI.groovy Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
* Search path configuration updates * Move methods from resolverUtils to build and impact utilities * Adding dependencySearch configurations to list of required build props * Removal of references of old DependencyResolver configuration in application-conf * Removal of references of old DependencyResolver configuration in MortgageApp Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
* Search path configuration updates * Move methods from resolverUtils to build and impact utilities * Adding dependencySearch configurations to list of required build props * Removal of references of old DependencyResolver configuration in application-conf * Removal of references of old DependencyResolver configuration in MortgageApp Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
At Cobol.groovy line 337 I added my codes to switch SYSLMOD from LOAD to CICSLOAD // If cics then the load will be CICSLOAD It looks like the ImpactUtilities.groovy is checking the LOAD only, and I have the following error, because my load module is at *** Scanning load module for raygenapp/base/src/COBOL/LGICDB01.cbl def saveStaticLinkDependencies(String buildFile, String loadPDS, LogicalFile logicalFile) { One way to circumvent my issue it to set cobol_scanLoadModule=false, however this will disable the cobol_scanLoadModule. |
See issue #262.
This PR is cleaning up the dependency and impact search configurations for the removed DependencyResolver and ImpactResolver APIs - see N&N in the DBB docs.
This PR includes: