Display message on missing build script mapping #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
M-DLB
reviewed
Aug 16, 2023
utilities/ImpactUtilities.groovy
Outdated
| @@ -109,8 +109,12 @@ def createImpactBuildList() { | |||
| // impactedFile found, but on Exclude List | |||
| // Possible reasons: Exclude of file was defined after building the collection. | |||
| // Rescan/Rebuild Collection to synchronize it with defined build scope. | |||
| if (props.verbose) println "!! $impactFile is impacted by changed file $changedFile, but is on Exlude List. Not added to build list." | |||
| if (props.verbose) println "*!* $impactFile is impacted by changed file $changedFile, but is on Exlude List. Not added to build list." | |||
There was a problem hiding this comment.
If I'm not wrong, the error messages start with *! and not *!*, can you change it to be consistent with other scripts?
utilities/ImpactUtilities.groovy
Outdated
| } | ||
| } else { | ||
| String warningMsg = "*!* $impactFile is impacted by changed file $changedFile, but is not added to build list, because it is not mapped to a language script." |
There was a problem hiding this comment.
If I'm not wrong, the error messages start with *! and not *!*, can you change it to be consistent with other scripts?
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
|
@M-DLB, good catch! The error indicator is fixed. |
M-DLB
approved these changes
Aug 16, 2023
ijmitch
pushed a commit
to ijmitch/dbb-zappbuild
that referenced
this pull request
Sep 12, 2023
…d impacted files (IBM#401) * Report warning when impacted file does not have a script mapping Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com> Signed-off-by: Ian J Mitchell <ianj_mitchell@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is providing a warning message to the console output independently of running in verbose logging mode, when during impact analysis an impacted file was detected, but is not mapped to a language script:
The msg is also added to the build result.