Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to changed files with user-provided baselineRef #506

Merged

Conversation

dennis-behm
Copy link
Member

This is extending the existing capability of zAppBuild to provide a user-friendly link to the changed files at the Git provider when providing the --impactBuild with the baselineRef sub-option.

See the configuration parameters gitRepositoryURL in the application configuration and gitRepositoryCompareService in build-conf/defaultzAppBuildConf.properties.

The property :gitchangedfiles:MortgageApplication contains the correct link in impactBuilds with baselineRef dennis-behm/dbb-zappbuild@main...5eb29f3

Verbose output log sample:

************* Creation and processing of the build list *************
** --impactBuild --baselineRef origin/main option selected. Building impacted programs for application MortgageApplication 
** Getting current hash for directory /u/dbehm/test-zapp/dbb-zappbuild/samples/MortgageApplication
** Storing MortgageApplication : 5eb29f3eca6fbd2638f40c5a8f3f7944705af421
** Getting baseline hash for directory /u/dbehm/test-zapp/dbb-zappbuild/samples/MortgageApplication
*** Baseline hash for directory MortgageApplication retrieved from overwrite.
** Storing MortgageApplication : origin/main
** Calculating changed files for directory /u/dbehm/test-zapp/dbb-zappbuild/samples/MortgageApplication
..
..
***************** Finalization of the build process *****************
*** Obtaining hash for directory /u/dbehm/test-zapp/dbb-zappbuild/samples/MortgageApplication
** Setting property :githash:MortgageApplication : 5eb29f3eca6fbd2638f40c5a8f3f7944705af421
** Setting property :giturl:MortgageApplication : https://github.com/dennis-behm/dbb-zappbuild.git
*** Baseline hash for directory MortgageApplication retrieved from overwrite.
** Setting property :gitchangedfiles:MortgageApplication : https://github.com/dennis-behm/dbb-zappbuild/compare/main...5eb29f3eca6fbd2638f40c5a8f3f7944705af421

Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
Signed-off-by: Dennis Behm <dennis.behm@de.ibm.com>
@dennis-behm dennis-behm requested a review from M-DLB April 25, 2024 08:40
@dennis-behm
Copy link
Member Author

zAppBuild TestFramework out
506.log

Copy link
Collaborator

@M-DLB M-DLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you @dennis-behm

@dennis-behm dennis-behm merged commit d9b80c1 into IBM:develop Apr 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants