Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation of object decks with deployType #551

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

M-DLB
Copy link
Collaborator

@M-DLB M-DLB commented Oct 14, 2024

This PR adds a "deploy type" to all Object decks generated during the build process. Object decks are now documented in the DBB Build Report, with an object type "OBJ". Object decks can be then processed and potentially integrated in the archive.

Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a new setting this name via a build property, similarly to the other deployTypes.

This is the sample for COBOL -

#
# default deployType
cobol_deployType=LOAD
#
# deployType for build files with isCICS=true
cobol_deployTypeCICS=CICSLOAD
#
# deployType for build files with isDLI=true
cobol_deployTypeDLI=IMSLOAD
#
# deployType for build files with isIMS=true
cobol_deployTypeIMS=IMSLOAD

For COBOL, it could be cobol_deployType_object, or cobol_object_deployType.

What are your thoughts on it?

@M-DLB
Copy link
Collaborator Author

M-DLB commented Oct 14, 2024

The problem is that we need to parse the build report afterward to extract these artifacts based on their deploy type. We could add a property for each type of artifacts, but it means we would need to add a property in packaging scripts to specify what is the deploy types associates to object decks. Do you want to add more properties?

Copy link
Member

@dennis-behm dennis-behm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these adjustments to flag any OBJ as a potential build output, that could be part of the package.

@dennis-behm dennis-behm merged commit bfacfd6 into IBM:develop Nov 6, 2024
1 check passed
dennis-behm pushed a commit to dennis-behm/dbb-zappbuild that referenced this pull request Nov 7, 2024
* Provide deployType for object decks
Signed-off-by: Mathieu Dalbin <mathieu.dalbin@fr.ibm.com>
@M-DLB M-DLB deleted the feature/addDeployTypesToObjects branch November 8, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants