This repository has been archived by the owner on Apr 11, 2023. It is now read-only.
feat: refactor alert task #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
Signed-off-by: Gabriel Valencia <gvalenc@us.ibm.com>
nfstein
approved these changes
Sep 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skit verification task split into separate tasks for:
Also, only one Slack msg will be sent instead of one for each retry, and missing links have been fixed. Only downside is that the
skit-verifytasks always looks like it succeeds even on failures. This is necessary due to a Tekton limitation where task results are not available if a task fails.Corresponding script updates are here: IBM/devex-skit-assets#80