fix: eliminate goroutine leak in the authenticators (#109)

IBM · Apr 22, 2021 · e5d921a · e5d921a
1 parent c795ac6
commit e5d921a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 22 deletions.
diff --git a/v5/core/cp4d_authenticator.go b/v5/core/cp4d_authenticator.go
@@ -201,17 +201,8 @@ func (authenticator *CloudPakForDataAuthenticator) getToken() (string, error) {
 		}
 	} else if authenticator.getTokenData().needsRefresh() {
 		// If refresh needed, kick off a go routine in the background to get a new token
-		ch := make(chan error)
-		go func() {
-			ch <- authenticator.invokeRequestTokenData()
-		}()
-		select {
-		case err := <-ch:
-			if err != nil {
-				return "", err
-			}
-		default:
-		}
+		//nolint: errcheck
+		go authenticator.invokeRequestTokenData()
 	}
 
 	// return an error if the access token is not valid or was not fetched

diff --git a/v5/core/iam_authenticator.go b/v5/core/iam_authenticator.go
@@ -213,17 +213,8 @@ func (authenticator *IamAuthenticator) getToken() (string, error) {
 		}
 	} else if authenticator.getTokenData().needsRefresh() {
 		// If refresh needed, kick off a go routine in the background to get a new token
-		ch := make(chan error)
-		go func() {
-			ch <- authenticator.invokeRequestTokenData()
-		}()
-		select {
-		case err := <-ch:
-			if err != nil {
-				return "", err
-			}
-		default:
-		}
+		//nolint: errcheck
+		go authenticator.invokeRequestTokenData()
 	}
 
 	// return an error if the access token is not valid or was not fetched