Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseService.Request invoked without result does not close http.Response #175

Closed
rafalbigaj opened this issue Feb 22, 2023 · 1 comment
Closed

BaseService.Request invoked without result does not close http.Response #175

rafalbigaj opened this issue Feb 22, 2023 · 1 comment
Labels
released

Comments

@rafalbigaj
Copy link
Member

The method BaseService.Request invoked without result (nil) does not close http.Response and prevents connection to be put back into idle state.

We observed significant memory usage or quick MaxConnsPerHost limit exhaustion, when BaseService.Request is called with nil result.
rafalbigaj added a commit to rafalbigaj/go-sdk-core that referenced this issue Feb 22, 2023
@rafalbigaj
fix: BaseService.Request invoked without result does not close http.R…
b03fa1f 
…esponse

The method BaseService.Request invoked without result (nil) does not close http.Response and prevents connection to be put back into idle state.

We observed significant memory usage or quick MaxConnsPerHost limit exhaustion, when BaseService.Request is called with nil result.

Issue: IBM#175
@rafalbigaj rafalbigaj mentioned this issue Feb 22, 2023
Merged
rafalbigaj added a commit to rafalbigaj/go-sdk-core that referenced this issue Feb 23, 2023
@rafalbigaj
fix: BaseService.Request invoked without result does not close http.R…
7a2bb59 
…esponse

The method BaseService.Request invoked without result (nil) does not close http.Response and prevents connection to be put back into idle state.

We observed significant memory usage or quick MaxConnsPerHost limit exhaustion, when BaseService.Request is called with nil result.

Issue: IBM#175
Signed-off-by: Rafał Bigaj <rafal.bigaj@pl.ibm.com>
@ibm-devx-sdk
Copy link

🎉 This issue has been resolved in version 5.12.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rafalbigaj @ibm-devx-sdk