Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: data race warnings #102

Merged
merged 8 commits into from
Mar 30, 2021
Merged

fix: data race warnings #102

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b8f9cb3
fix: make cp4d authenticator token data thread safe
pyrooka Mar 22, 2021
9328f16
fix: make IAM authenticator token data thread safe
pyrooka Mar 23, 2021
358a8bf
fix: use mutex to prevent data race for "requestCount" in the retries…
pyrooka Mar 25, 2021
6a55707
chore: typo
pyrooka Mar 25, 2021
f492206
chore: fix govet copylocks error
pyrooka Mar 25, 2021
a61fff4
chore: fix interface nil value check
pyrooka Mar 26, 2021
1855dbe
chore: add test for nil interface value in the authenticator
pyrooka Mar 26, 2021
03ce576
chore: fix lint error
pyrooka Mar 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions v5/core/cp4d_authenticator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,15 +129,15 @@ func newCloudPakForDataAuthenticatorFromMap(properties map[string]string) (*Clou
}

// AuthenticationType returns the authentication type for this authenticator.
func (CloudPakForDataAuthenticator) AuthenticationType() string {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if is there a specific reason why this used as a value or not, but hopefully changing it to pointer won't break anything. All tests passed btw.

@padamstx What's your take on this?

func (*CloudPakForDataAuthenticator) AuthenticationType() string {
return AUTHTYPE_CP4D
}

// Validate the authenticator's configuration.
//
// Ensures the username, password, and url are not Nil. Additionally, ensures
// they do not contain invalid characters.
func (authenticator CloudPakForDataAuthenticator) Validate() error {
func (authenticator *CloudPakForDataAuthenticator) Validate() error {

if authenticator.Username == "" {
return fmt.Errorf(ERRORMSG_PROP_MISSING, "Username")
Expand Down
4 changes: 2 additions & 2 deletions v5/core/iam_authenticator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func newIamAuthenticatorFromMap(properties map[string]string) (authenticator *Ia
}

// AuthenticationType returns the authentication type for this authenticator.
func (IamAuthenticator) AuthenticationType() string {
func (*IamAuthenticator) AuthenticationType() string {
return AUTHTYPE_IAM
}

Expand Down Expand Up @@ -175,7 +175,7 @@ func (authenticator *IamAuthenticator) setTokenData(tokenData *iamTokenData) {
//
// Ensures the ApiKey is valid, and the ClientId and ClientSecret pair are
// mutually inclusive.
func (this IamAuthenticator) Validate() error {
func (this *IamAuthenticator) Validate() error {
if this.ApiKey == "" {
return fmt.Errorf(ERRORMSG_PROP_MISSING, "ApiKey")
}
Expand Down