Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): bump min go version to 1.14 #140

Merged
merged 3 commits into from
Oct 7, 2021
Merged

feat(build): bump min go version to 1.14 #140

merged 3 commits into from
Oct 7, 2021

Conversation

padamstx
Copy link
Member

@padamstx padamstx commented Oct 1, 2021

This PR moves us up to node 14 to support the new v18 of semantic-release.

@padamstx padamstx self-assigned this Oct 1, 2021
@padamstx padamstx requested a review from dpopp07 October 1, 2021 00:39
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

This commit includes changes to the go.mod file
to bump the minimum version of go supported by this
module from 1.12 to 1.14.
@padamstx padamstx changed the title chore(build): bump node to 14 to support new semantic-release feat(build): bump min go version to 1.14 Oct 6, 2021
@padamstx
Copy link
Member Author

padamstx commented Oct 6, 2021

I've added an additional commit to bump up our min supported go version to 1.14.
This is needed because a few of our dependencies require a go version newer than 1.12 (our previous min version).

@padamstx padamstx requested a review from pyrooka October 6, 2021 22:32
Copy link
Member

@pyrooka pyrooka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit eb86886 into main Oct 7, 2021
@padamstx padamstx deleted the fix-semrel branch October 7, 2021 14:52
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 5.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

ibm-devx-sdk pushed a commit that referenced this pull request Oct 7, 2021
# [5.7.0](v5.6.5...v5.7.0) (2021-10-07)

### Features

* **build:** bump min go version to 1.14 ([#140](#140)) ([eb86886](eb86886))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants