-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MCSPAuthenticator): add new authenticator for Multi-Cloud Saas Platform #198
Conversation
87fe96a
to
b226307
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Found some potential typos to consider but no feedback on the implementation from my side
54a0c24
to
b4cc9a7
Compare
### Usage Notes | ||
- When constructing an MCSPAuthenticator instance, you must specify the ApiKey and URL properties. | ||
|
||
- The authenticator will use the token server's `POST /siusermgr/api/1.0/apikeys/token` operation to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The readme looks good to me, although I am curious as to what this /siusermgr/api/1.0/apikeys/token
endpoint is. Is this something users will need to be worried about or could potentially want to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, that's just the "path" associated with the operation that the authenticator invokes. I just added that statement so that curious users (and developers) would know which specific operation the authenticator is using to do the token exchange.
86d05af
to
35a1cde
Compare
…latform This commit introduces the new MCSPAuthenticator that can be used to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation. Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
35a1cde
to
5a39765
Compare
# [5.15.0](v5.14.1...v5.15.0) (2023-11-15) ### Features * **MCSPAuthenticator:** add new authenticator for Multi-Cloud Saas Platform ([#198](#198)) ([8987085](8987085))
🎉 This PR is included in version 5.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This commit introduces the new MCSPAuthenticator that can be used to exchange an apikey for an MCSP access token using the Multi-Cloud Saas Platform authentication token server's 'POST /siusermgr/api/1.0/apikeys/token' operation.