Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable storageClass configuration for EDB wal #1781

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Enable storageClass configuration for EDB wal #1781

merged 1 commit into from
Jan 30, 2024

Conversation

Daniel-Fan
Copy link
Contributor

issue: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/62016

Support storageClass configuration .spec.walStorage.storageClass for EDB Cluster CR named keycloak-edb-cluster

...
walStorage:
  resizeInUseVolumes: true
  size: 1Gi
  storageClass: rook-ceph-block
maxSyncReplicas: 0
switchoverDelay: 3600
storage:
  resizeInUseVolumes: true
  size: 1Gi
  storageClass: rook-ceph-block
description: EDB Database with IBM License Key

@Daniel-Fan
Enable storageClass configuration for EDB wal
20aa202 
Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
@Daniel-Fan Daniel-Fan requested review from YCShen1010 and removed request for bluzarraga and qpdpQ January 30, 2024 21:55
YCShen1010
YCShen1010 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@YCShen1010 YCShen1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 360784e into IBM:master Jan 30, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YCShen1010 YCShen1010 YCShen1010 approved these changes

Assignees

@YCShen1010 YCShen1010

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Daniel-Fan @ibm-ci-bot @YCShen1010