Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable customization for common-service-db Cluster CR #1804

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

YCShen1010
Copy link
Contributor

issue: https://github.ibm.com/ibmprivatecloud/roadmap/issues/62292

  • Include size setting into the rules template
  • Incorporate resource instance values to the T-shirt size
  • Add CPU, memory limitation

memory: LARGEST_VALUE
requests:
cpu: LARGEST_VALUE
memory: LARGEST_VALUE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies on missing this....
Could we add a ephemeral-storage: LARGEST_VALUE here as well?

Signed-off-by: YuChen <yuchen.shen@mail.utoronto.ca>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit e7a05b2 into IBM:master Feb 21, 2024
6 of 7 checks passed
@YCShen1010 YCShen1010 deleted the config_db branch February 21, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants