Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable StorageClass configuration for common-service-db #1812

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

YCShen1010
Copy link
Contributor

@YCShen1010 YCShen1010 commented Feb 23, 2024

Issue:https://github.ibm.com/IBMPrivateCloud/roadmap/issues/62395

Context

Added a storageClass template for common-service-db, so that when the user configures the storageClass in the CommonService CR, the custom storageClass will be added to the common-service-db resource in OperandConfig and synchronized in the Cluster CR.

How to test

test image: quay.io/yuchen_shen/cs_operator:csdb_sc

  1. Request common-service-postgresql without configure storageClass in CommonService CR, there will be no storageClass section for common-service-db in Cluster CR
  2. Apply the test image, configure a storageClass in CS CR
  3. Delete common-service OpCon and common-service-db Cluster CR and restart ODLM pod
  4. Observe the custom sc will be added in OperandConfig and existing common-service-db Cluster CR

example:

storage:
    resizeInUseVolumes: true
    size: 1Gi
    storageClass: <storage-class-name>

Signed-off-by: YuChen <yuchen.shen@mail.utoronto.ca>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 82e038f into IBM:master Feb 23, 2024
6 of 9 checks passed
@YCShen1010 YCShen1010 deleted the csdb_sc branch February 24, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants