Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default size profile and instance from OperandConfig template #1883

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

YCShen1010
Copy link
Contributor

Issue: https://github.ibm.com/ibmprivatecloud/roadmap/issues/61284

After implementing the ODLM's capability to deep merge Kubernetes resources logic, we could remove the default size profile and instance in OperandConfig template. Therefore, we should observe a consistent change in the number of instances during common-service reconciliation, rather than fluctuating between 3, 1, and 3.

Before removing the hardcoded size and instance:

  1. When deploying KeyCloak for the first time, the instance created in KeyCloak CR would be 1.
  2. Then if the user configures a large size in CS CR, the instance will change to 3.
  3. If it is upgraded to a new version, we will observe the instance changing back to 1, as CS applies the default value of 1 from OperandConfig during reconciliation.
  4. Finally, it will ultimately change to 3, as the size is configured as large in the CS CR

After removing:

  1. The instance would always remain 3 without alteration, as long as the user configures it to a large size.

Signed-off-by: YuChen <yuchen.shen@mail.utoronto.ca>
Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, YCShen1010

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,YCShen1010]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit 7ca5c33 into IBM:master Mar 28, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants