Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote array value for annotations #1889

Merged
merged 1 commit into from
Mar 29, 2024
Merged

quote array value for annotations #1889

merged 1 commit into from
Mar 29, 2024

Conversation

Daniel-Fan
Copy link
Contributor

To unblock the error on rendering OperandConfig, json could not unmarshal array ["velero"] into annotation value string, need to quote the array '["velero"]'

E0329 04:25:33.828268 1 init.go:710] failed to concatenate OperandConfig: failed to fetch data of OprandConfig hugepages/common-service: error unmarshaling JSON: json: cannot unmarshal array into Go struct field ConfigResource.spec.services.resources.annotations of type string
E0329 04:25:33.835020 1 commonservice_controller.go:227] Fail to reconcile hugepages/common-service: failed to fetch data of OprandConfig hugepages/common-service: error unmarshaling JSON: json: cannot unmarshal array into Go struct field ConfigResource.spec.services.resources.annotations of type string
2024-03-29T04:25:33.835Z ERROR controller.commonservice Reconciler error {"reconciler group": "operator.ibm.com", "reconciler kind": "CommonService", "name": "common-service", "namespace": "hugepages", "error": "failed to fetch data of OprandConfig hugepages/common-service: error unmarshaling JSON: json: cannot unmarshal array into Go struct field ConfigResource.spec.services.resources.annotations of type string"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.10.0/pkg/internal/controller/controller.go:227

Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, Daniel-Fan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,bitscuit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit c6afe10 into IBM:master Mar 29, 2024
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants