Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add velero plugin to im edb cluster config by default #1901

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

bluzarraga
Copy link
Member

By default, we want to enable the velero backup addon for IM EDB cluster. This way, in all use cases except CP4D, IM EDB will follow the officially supported BR process for EDB. In the CP4D case where IM EDB will be sharing cluster config with zen, CP4D will overwrite the annotation with their own via the CommonService CR. This will remove the ability to backup IM via velero plugin so we will have a fork in the instructions to specify using the pgdump approach instead. I stuck with calling the velero label cs-db instead of cs-db-data as we already have in scripts to facilitate this use case based fork.

Discussion welcome.

Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
Signed-off-by: Ben Luzarraga <luzarragaben@gmail.com>
@bluzarraga
Copy link
Member Author

Meant to add this comment to this PR but accidentally placed it on 1902: #1902 (comment)
Copy/pasting for clarity here:

A couple reasons to put this on hold after discussion with Yanni:
- DCUT has already passed
- velero bug has not technically been solved on the EDB side
- not fully understood how the overwriting of the addon annotation will work out, currently just have a theoretical understanding
- the only adopters of 4.6 are CPD who are most affected by this change

essentially, more can go wrong by including this early than can be gained. Better to target in 4.6.1

@bluzarraga
Copy link
Member Author

defer to 4.6.2

Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bluzarraga, Daniel-Fan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,bluzarraga]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot merged commit ebc1596 into IBM:master Apr 26, 2024
6 of 8 checks passed
@bluzarraga bluzarraga deleted the enable-velero-plugin-im-edb branch October 9, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants