Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CRD to be forward compatible #1906

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

Daniel-Fan
Copy link
Contributor

Add preserve unknown field for CS CR field .spec.services[*]

apiVersion: operator.ibm.com/v3
kind: CommonService
metadata:
  name: common-service
spec:
  license:
    accept: false
  operatorNamespace: cs-condition
  servicesNamespace: cs-condition
  size: starterset
  services:
     - name: ibm-im-operator
       resources:
          - xxxx
       spec:
            xxxx
       ...  # Any arbitrary field

Signed-off-by: Daniel Fan <fanyuchensx@gmail.com>
Copy link
Member

@bitscuit bitscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bitscuit, Daniel-Fan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Daniel-Fan,bitscuit]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot added the lgtm label Apr 4, 2024
@ibm-ci-bot ibm-ci-bot merged commit 1621079 into IBM:master Apr 4, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants