Ensure that DeletionTimestamp exists before patching the finalizers #1921
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
https://github.ibm.com/IBMPrivateCloud/roadmap/issues/61273
https://github.ibm.com/IBMPrivateCloud/roadmap/issues/61040
Issue description
In the AllNamespace/SingleNamespace migration path, NSS
NamespaceScope
resources failed to be deleted automatically during the initial run. However, upon restarting the CS pod, they will eventually be removedEnhancement
PollImmediate
function to address the timing issue where the deletion timestamp might not be available immediately after deletionHow to verify
Test image: quay.io/yuchen_shen/cs_operator:nss_cleanup
NamespaceScope
resources underibm-common-services
nsAfter applying the image: restart CS pod(only once), those resources will be deleted eventualy