feat(config): support multiple profiles #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilartomas
force-pushed
the
feat-profiles
branch
from
26f853c
to
920c40d
Compare
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
pilartomas
force-pushed
the
feat-profiles
branch
from
920c40d
to
3876baa
Compare
pilartomas
commented
Aug 28, 2023
|
|
||
| try { | ||
| await parser.parse(); | ||
| await parser.config(loadYargsConfig()).parse(); |
There was a problem hiding this comment.
We want to catch load errors
Tomas2D
approved these changes
Aug 29, 2023
Tomas2D
reviewed
Aug 31, 2023
Comment on lines
+12
to
+14
| Object.entries(profileConfig).forEach(([key, value]) => { | ||
| args[key] = value; | ||
| }); |
There was a problem hiding this comment.
💡 This can probably be replaced with the following:
Object.assign(args, profileConfig)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.