fix(config): improve and secure config UX #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pilartomas
force-pushed
the
fix-config-command
branch
from
ee65f0c
to
77ed524
Compare
pilartomas
force-pushed
the
fix-config-command
branch
from
77ed524
to
37a0931
Compare
pilartomas
force-pushed
the
fix-config-command
branch
2 times, most recently
from
7fbd3dd
to
bd903b9
Compare
pilartomas
force-pushed
the
fix-config-command
branch
from
bd903b9
to
72573ed
Compare
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
pilartomas
force-pushed
the
fix-config-command
branch
from
72573ed
to
e2c1193
Compare
Tomas2D
requested changes
Aug 31, 2023
| ...credentials, | ||
| ...(profile && credentials.profiles && credentials.profiles[profile]), | ||
| }; |
There was a problem hiding this comment.
This type of merging will not handle undefined values. Is it okay?
There was a problem hiding this comment.
Can you reiterate? Spreading variable with undefined value should work just fine.
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
pilartomas
force-pushed
the
fix-config-command
branch
from
bd8df50
to
7d1b709
Compare
Tomas2D
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Miscellaneous fixes and improvements of the configuration command.
profilescommand to list commands