-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): SDK update and interface overhaul #32
Conversation
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
.eslintrc.yml
Outdated
@@ -8,7 +8,7 @@ extends: | |||
plugins: | |||
- import | |||
parserOptions: | |||
ecmaVersion: "latest" | |||
ecmaVersion: 14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the "latest" in there.
TypeScript would tell us if the given functionality is not supported
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were getting some false positives from the linter, this was a bypass. I can no longer replicate the problem though, changing it back.
No description provided.