Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): SDK update and interface overhaul #32

Merged
merged 10 commits into from
Mar 12, 2024
Merged

Conversation

pilartomas
Copy link
Collaborator

No description provided.

Tomas Pilar added 9 commits December 28, 2023 11:36
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
@pilartomas pilartomas requested a review from Tomas2D March 12, 2024 10:56
.eslintrc.yml Outdated
@@ -8,7 +8,7 @@ extends:
plugins:
- import
parserOptions:
ecmaVersion: "latest"
ecmaVersion: 14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the "latest" in there.

TypeScript would tell us if the given functionality is not supported

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were getting some false positives from the linter, this was a bypass. I can no longer replicate the problem though, changing it back.

Signed-off-by: Tomas Pilar <tomas.pilar@ibm.com>
@pilartomas pilartomas merged commit 83d5b48 into main Mar 12, 2024
7 checks passed
@pilartomas pilartomas deleted the v2-interface-overhaul branch March 12, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants