Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade k8s and other dependencies from 1.28 to 1.30 #45

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Conversation

sameshai
Copy link
Member

@sameshai sameshai commented Aug 19, 2024

Disabled below checks and few others due to false positives.

go get github.com/pierrre/gotestcover
golangci-lint run --disable-all --enable=gofmt --fix
WARN The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.
WARN The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner. Replaced by revive.
WARN The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused.

ERRO [linters_context] deadcode: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] golint: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] structcheck: This linter is fully inactivated: it will not produce any reports.
ERRO [linters_context] varcheck: This linter is fully inactivated: it will not produce any reports.

@sameshai sameshai self-assigned this Aug 19, 2024
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
Copy link
Member

@skorati skorati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Sameer Shaikh <sameer.shaikh@ibm.com>
@sameshai sameshai merged commit 930828c into master Aug 20, 2024
3 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants