-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow java16+ as JRE #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This commit includes a small change to the AbstractToken class to avoid an InaccessibleObjectException when running code using a Java 16 (or later) JRE.
ce9b664
to
480f3ad
Compare
## [9.16.1](9.16.0...9.16.1) (2022-03-23) ### Bug Fixes * allow java16+ as JRE ([#171](#171)) ([95ea237](95ea237))
🎉 This PR is included in version 9.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thank you! This fixed an error I reported from a few months ago. |
This commit includes a small change to the AbstractToken
class to avoid an InaccessibleObjectException when
running code using a Java 17 JRE.
In addition, the pom.xml was updated to make it easy
to build/test with a Java 17 JDK... just add "-P java17"
to the mvn command line.
Note: although we don't yet include a java17-based build in Travis, I've tested locally and with the changes in this PR, I'm able to build and test the project cleanly by running
mvn clean install -P java17
while using the Oracle Java 17 JDK.Unfortunately, I have to use the
--add-opens
JVM option when running unit tests due to InaccessibleObjectException's thatoccur in some of our dependencies (mostly powermock, etc.).