fix: allow java16+ as JRE #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padamstx
commented
Mar 23, 2022
padamstx
commented
Mar 23, 2022
padamstx
commented
Mar 23, 2022
padamstx
commented
Mar 23, 2022
This commit includes a small change to the AbstractToken class to avoid an InaccessibleObjectException when running code using a Java 16 (or later) JRE.
padamstx
force-pushed
the
support-java17
branch
from
ce9b664
to
480f3ad
Compare
ricellis
approved these changes
Mar 23, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Mar 23, 2022
## [9.16.1](9.16.0...9.16.1) (2022-03-23) ### Bug Fixes * allow java16+ as JRE ([#171](#171)) ([95ea237](95ea237))
|
🎉 This PR is included in version 9.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Thank you! This fixed an error I reported from a few months ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes a small change to the AbstractToken
class to avoid an InaccessibleObjectException when
running code using a Java 17 JRE.
In addition, the pom.xml was updated to make it easy
to build/test with a Java 17 JDK... just add "-P java17"
to the mvn command line.
Note: although we don't yet include a java17-based build in Travis, I've tested locally and with the changes in this PR, I'm able to build and test the project cleanly by running
mvn clean install -P java17while using the Oracle Java 17 JDK.Unfortunately, I have to use the
--add-opensJVM option when running unit tests due to InaccessibleObjectException's thatoccur in some of our dependencies (mostly powermock, etc.).