Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RequestBuilder): retain trailing slash on operation path #206

Merged
merged 1 commit into from
May 24, 2023

Conversation

padamstx
Copy link
Member

This PR fixes RequestBuilder.resolveRequestUrl() so that it will retain a trailing slash found on an operation path when adding the path segments to form the request URL.

Signed-off-by: Phil Adams <phil_adams@us.ibm.com>
@padamstx padamstx self-assigned this May 23, 2023
@padamstx padamstx requested a review from dpopp07 May 23, 2023 21:11
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@padamstx padamstx merged commit aa22d28 into main May 24, 2023
@padamstx padamstx deleted the path-slash-fix branch May 24, 2023 15:14
ibm-devx-sdk pushed a commit that referenced this pull request May 24, 2023
## [9.18.4](9.18.3...9.18.4) (2023-05-24)

### Bug Fixes

* **RequestBuilder:** retain trailing slash on operation path ([#206](#206)) ([aa22d28](aa22d28))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 9.18.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants