Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use 30/70 split for LeftNavSidecar #4456

Merged
merged 1 commit into from
May 4, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented May 4, 2020

Fixes #4454

this also improves ls -l rendering in narrower windows, which are going to happen more often, with a 30/70 split
Fixes #4455

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

Fixes kubernetes-sigs#4454

this also improves ls -l rendering in narrower windows, which are going to happen more often, with a 30/70 split
Fixes kubernetes-sigs#4455
@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #4456 into master will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4456      +/-   ##
==========================================
+ Coverage   59.12%   59.25%   +0.12%     
==========================================
  Files          75       75              
  Lines        2410     2410              
  Branches      582      582              
==========================================
+ Hits         1425     1428       +3     
+ Misses        760      755       -5     
- Partials      225      227       +2     
Impacted Files Coverage Δ
packages/core/src/util/i18n.ts 56.00% <0.00%> (-8.00%) ⬇️
packages/core/src/core/command-tree.ts 72.32% <0.00%> (+0.89%) ⬆️
packages/core/src/core/userdata.ts 68.05% <0.00%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d66e71f...cfc8682. Read the comment docs.

@starpit starpit merged commit 9a43d0b into kubernetes-sigs:master May 4, 2020
@starpit starpit deleted the fix-4454 branch May 4, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ls -l output doesn't look great with sidecar open in narrower windows consider making LeftNavSidecar wider?
1 participant