Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider making LeftNavSidecar wider? #4454

Closed
starpit opened this issue May 4, 2020 · 3 comments · Fixed by #4456
Closed

consider making LeftNavSidecar wider? #4454

starpit opened this issue May 4, 2020 · 3 comments · Fixed by #4456

Comments

@starpit
Copy link
Contributor

starpit commented May 4, 2020

Right now, it takes up 45% of the window width. This results in a fair amount of ellision and line wrapping in kubectl help.

Suggestion: maybe try a 30/70 split? rather than a 55/45 split? The thinking here is that help is important and deserves space.
@starpit
Copy link
Contributor Author

starpit commented May 4, 2020 •
edited
Loading

with the existing 55/45 split: about 55:45

@starpit
Copy link
Contributor Author

starpit commented May 4, 2020

with the proposed 30/70 split: about 30-70

@starpit
Copy link
Contributor Author

starpit commented May 4, 2020

this probably requires a fix for #4455 since we'll be making the Terminal quite narrow

starpit added a commit to starpit/kui that referenced this issue May 4, 2020
@starpit
fix: use 30/70 split for LeftNavSidecar
0011edc 
Fixes kubernetes-sigs#4454

this also improves ls -l rendering in narrower windows, which are going to happen more often, with a 30/70 split
Fixes kubernetes-sigs#4455
@starpit starpit mentioned this issue May 4, 2020
Merged
7 tasks
starpit added a commit to starpit/kui that referenced this issue May 4, 2020
@starpit
fix: use 30/70 split for LeftNavSidecar
cfc8682 
Fixes kubernetes-sigs#4454

this also improves ls -l rendering in narrower windows, which are going to happen more often, with a 30/70 split
Fixes kubernetes-sigs#4455
starpit added a commit that referenced this issue May 4, 2020
@starpit
fix: use 30/70 split for LeftNavSidecar
9a43d0b 
Fixes #4454

this also improves ls -l rendering in narrower windows, which are going to happen more often, with a 30/70 split
Fixes #4455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use 30/70 split for LeftNavSidecar starpit/kui
1 participant
@starpit