Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clicking on certain links in kubectl help result in odd behavior #4474

Merged
merged 1 commit into from
May 5, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented May 5, 2020

Fixes #4473

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #4474 into master will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4474      +/-   ##
==========================================
+ Coverage   59.04%   59.12%   +0.08%     
==========================================
  Files          75       75              
  Lines        2410     2410              
  Branches      582      582              
==========================================
+ Hits         1423     1425       +2     
+ Misses        762      760       -2     
  Partials      225      225              
Impacted Files Coverage Δ
packages/core/src/repl/tab-completion.ts 73.33% <0.00%> (ø)
packages/core/src/util/i18n.ts 64.00% <0.00%> (+8.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 995b129...340a9f1. Read the comment docs.

@starpit starpit merged commit 035894b into kubernetes-sigs:master May 5, 2020
@starpit starpit deleted the fix-4473 branch May 5, 2020 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some markdown links from kubectl help have buggy onclick behavior
1 participant