fix: clicking on certain links in kubectl help result in odd behavior

Fixes #4473
kubernetes-sigs · May 5, 2020 · 035894b · 035894b
1 parent 8941dd0
commit 035894b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/plugins/plugin-client-common/src/components/Content/Markdown.tsx b/plugins/plugin-client-common/src/components/Content/Markdown.tsx
@@ -72,7 +72,12 @@ export default class Markdown extends React.PureComponent<Props> {
               ? undefined
               : async () => {
                   let file = props.href
-                  if (props.href.charAt(0) === '#') {
+                  if (props.href.startsWith('#kuiexec?command=')) {
+                    const cmdline = decodeURIComponent(props.href.slice('#kuiexec?command='.length))
+                    if (cmdline) {
+                      return this.props.repl.pexec(cmdline)
+                    }
+                  } else if (props.href.charAt(0) === '#') {
                     const elt = this.props.tab.querySelector(
                       `[data-markdown-anchor="${this.anchorFrom(props.href.slice(1))}"]`
                     )

diff --git a/plugins/plugin-kubectl/src/lib/util/help.ts b/plugins/plugin-kubectl/src/lib/util/help.ts
@@ -115,7 +115,7 @@ const renderHelpUnsafe = (
       .map(_ =>
         _.replace(
           /"([^"]+)"/g,
-          (_, command) => `[${command}](kui://exec?command=${encodeURIComponent(command)} "Execute ${command}")`
+          (_, command) => `[${command}](#kuiexec?command=${encodeURIComponent(command)} "Execute ${command}")`
         )
       )
       // .map(_ => ` - ${_}`)