Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split screen Terminal #4815

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Jun 4, 2020

Fixes #4814

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

@starpit starpit force-pushed the split branch 2 times, most recently from d54ae7e to 5c1fc82 Compare June 4, 2020 23:39
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #4815 into master will increase coverage by 0.07%.
The diff coverage is 75.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4815      +/-   ##
==========================================
+ Coverage   59.59%   59.66%   +0.07%     
==========================================
  Files          77       77              
  Lines        2408     2452      +44     
  Branches      588      604      +16     
==========================================
+ Hits         1435     1463      +28     
- Misses        746      759      +13     
- Partials      227      230       +3     
Impacted Files Coverage Δ
packages/core/src/index.ts 100.00% <ø> (ø)
packages/core/src/models/NavResponse.ts 100.00% <ø> (ø)
packages/core/src/models/execOptions.ts 60.00% <ø> (ø)
packages/core/src/models/mmr/types.ts 100.00% <ø> (ø)
packages/core/src/webapp/queueing.ts 70.00% <ø> (-1.43%) ⬇️
packages/core/src/core/events.ts 75.36% <70.68%> (-17.98%) ⬇️
packages/core/src/webapp/tab.ts 71.42% <77.77%> (+4.76%) ⬆️
packages/core/src/repl/exec.ts 74.30% <100.00%> (-1.09%) ⬇️
packages/core/src/webapp/cancel.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7490b34...3a9f1a7. Read the comment docs.

@starpit starpit force-pushed the split branch 4 times, most recently from 4ad6332 to 4813e05 Compare June 5, 2020 15:03
@starpit starpit force-pushed the split branch 8 times, most recently from 40ec6bc to 9ae893b Compare June 8, 2020 23:02
@starpit starpit merged commit 3a6b422 into kubernetes-sigs:master Jun 9, 2020
@starpit starpit deleted the split branch June 9, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: split pane support
1 participant