Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: split pane support #4814

Closed
starpit opened this issue Jun 4, 2020 · 1 comment · Fixed by #4815
Closed

Feature: split pane support #4814

starpit opened this issue Jun 4, 2020 · 1 comment · Fixed by #4815
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@starpit
Copy link
Contributor

starpit commented Jun 4, 2020

  1. it'd be nice to have split panes.
  2. we could use these as a better host for the watch panes
  3. we need to clean up and declare types for the Command lifecycle events; this will be important with split terminals
@starpit
Copy link
Contributor Author

starpit commented Jun 4, 2020

Architecture

  • ScrollableTerminal will encapsulate the splits
  • It will implement a Tab facade so that command lifecycle events can be directed to a particular split
  • This shouldn't require many changes elsewhere. But... we will need to improve the event substrate. Right now, we are using the untyped eventChannelUnsafe. We should use this opportunity to type it up. The types will be in events.ts, where eventBus is normally situated, but updated with newly-typed event channels related to the lifecycle of command execution.

starpit added a commit to starpit/kui that referenced this issue Jun 4, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2020
@starpit starpit self-assigned this Jun 4, 2020
@starpit starpit added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 4, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 4, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 5, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 6, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 6, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 7, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 7, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 8, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 8, 2020
starpit added a commit to starpit/kui that referenced this issue Jun 8, 2020
starpit added a commit that referenced this issue Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant